Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New new new backend part 4: converting the xrender backend #1238

Merged
merged 5 commits into from
Apr 14, 2024

Conversation

yshui
Copy link
Owner

@yshui yshui commented Apr 12, 2024

No description provided.

Copy link

codecov bot commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 8.80829% with 352 lines in your changes are missing coverage. Please review.

Project coverage is 37.63%. Comparing base (5c897d7) to head (d3e2bd0).
Report is 1 commits behind head on next.

❗ Current head d3e2bd0 differs from pull request most recent head f088073. Consider uploading reports for the commit f088073 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #1238      +/-   ##
==========================================
+ Coverage   37.38%   37.63%   +0.24%     
==========================================
  Files          55       55              
  Lines       12283    12279       -4     
==========================================
+ Hits         4592     4621      +29     
+ Misses       7691     7658      -33     
Files Coverage Δ
src/x.h 82.92% <ø> (ø)
src/x.c 42.10% <57.14%> (+5.14%) ⬆️
src/render.c 0.57% <0.00%> (-0.01%) ⬇️
src/backend/dummy/dummy.c 63.54% <50.00%> (ø)
src/backend/xrender/xrender.c 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

@yshui yshui force-pushed the new-new-new-backend-dummy branch from b774b50 to edbb42f Compare April 12, 2024 13:30
@yshui yshui force-pushed the new-new-new-backend-xrender branch from 9e4ebb2 to 0513918 Compare April 12, 2024 13:31
@yshui yshui force-pushed the new-new-new-backend-dummy branch from edbb42f to 5c897d7 Compare April 14, 2024 08:14
Base automatically changed from new-new-new-backend-dummy to next April 14, 2024 08:15
Morphing xrender_compose_impl to look like the blit operation. Also move
the rounded corner cache to xrender image inner, since we are going to
get rid of the image properties abstraction, so there is no space for it
there anymore.

Signed-off-by: Yuxuan Shui <[email protected]>
The compatibility layer has its own, so no need for another one in the
xrender backend.

Signed-off-by: Yuxuan Shui <[email protected]>
@yshui yshui force-pushed the new-new-new-backend-xrender branch from d3e2bd0 to f088073 Compare April 14, 2024 08:16
@yshui yshui enabled auto-merge April 14, 2024 08:16
@yshui yshui merged commit 6e9d21b into next Apr 14, 2024
14 of 15 checks passed
@yshui yshui deleted the new-new-new-backend-xrender branch April 14, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant