Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend: gl: convert the shadow color to the premultiplied format #1124

Merged
merged 1 commit into from
Dec 16, 2023

Conversation

absolutelynothelix
Copy link
Collaborator

to respect the globally set glBlendFunc and thus get the correct and expected result

closes #1123

@codecov
Copy link

codecov bot commented Sep 10, 2023

Codecov Report

Merging #1124 (e07b1d7) into next (751f305) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #1124      +/-   ##
==========================================
- Coverage   37.55%   37.55%   -0.01%     
==========================================
  Files          49       49              
  Lines       11181    11182       +1     
==========================================
  Hits         4199     4199              
- Misses       6982     6983       +1     
Files Changed Coverage Δ
src/backend/gl/gl_common.c 25.40% <0.00%> (-0.04%) ⬇️

to respect the globally set glBlendFunc and thus get the correct and
expected result
@yshui
Copy link
Owner

yshui commented Dec 16, 2023

LGTM, thanks!

@yshui yshui merged commit 8b7c3ff into yshui:next Dec 16, 2023
6 checks passed
@absolutelynothelix absolutelynothelix deleted the premultiply-shadow-color branch December 16, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shadow opacity does not work if the shadow-color is not black (glx backend)
2 participants