core: isolate X connection with error handling into a struct #1087
Conversation
Codecov Report
@@ Coverage Diff @@
## next #1087 +/- ##
==========================================
- Coverage 37.67% 37.56% -0.12%
==========================================
Files 49 49
Lines 11168 11190 +22
==========================================
- Hits 4208 4203 -5
- Misses 6960 6987 +27
|
yshui
force-pushed
the
struct-x-connection
branch
from
409f1bc
to
11a091c
Compare
There was a problem hiding this comment.
there are a lot of unrelated style and formatting changes. they should either be pushed directly and the pull request should be based on them or be a separate commit(s) because they make the actual reviewing harder and slower. the same applies to the unrelated logic changes. all of these changes are good but they should be separated to make reviewing easy. to prevent this in the future i suggest you to at least run clang-format on all .c and .h files and do a direct push.
overall, lgtm.
btw, a reminder. this todo seems to be related to these changes:
Line 491 in d4f7282
yshui
force-pushed
the
struct-x-connection
branch
from
11a091c
to
9d5dfd3
Compare
|
@absolutelynothelix I've fixed all your points. thanks for the review btw.
I think this comment is referring to the |
Part of the long running effort to reduce the prevalence of `session_t`. After this, functions that communicate with X can make use of the error handling machinary (set_ignore_cookie, set_cant_fail_cookie) without needing to take a `session_t` parameter. This commit converts everything to use the new struct `x_connection`, most of the conversions are mechanical. Signed-off-by: Yuxuan Shui <[email protected]>
Signed-off-by: Yuxuan Shui <[email protected]>
yshui
force-pushed
the
struct-x-connection
branch
from
9d5dfd3
to
6bd780f
Compare
yeah, i think you wanted to separate the |
Part of the long running effort to reduce the prevalence of
session_t. After this, functions that communicate with X can make use of the error handling machinary (set_ignore_cookie, set_cant_fail_cookie) without needing to take asession_tparameter.This commit converts everything to use the new struct
x_connection, most of the conversions are mechanical.