Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend: xrender: force 32bit ARGB visual when adding rounded corners #1003

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

tryone144
Copy link
Collaborator

Force the temporary picture to a 32-bit ARGB visual when masking it for rounded corners to keep the transparency information. Otherwise, windows with a 24-bit visual would get black corners instead.

Related: #997

@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Merging #1003 (fd9c52d) into next (e60cb65) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #1003      +/-   ##
==========================================
- Coverage   37.56%   37.55%   -0.02%     
==========================================
  Files          49       49              
  Lines       11193    11197       +4     
==========================================
  Hits         4205     4205              
- Misses       6988     6992       +4     
Files Coverage Δ
src/backend/xrender/xrender.c 0.00% <0.00%> (ø)

@absolutelynothelix
Copy link
Collaborator

absolutelynothelix commented Jan 20, 2023

nice, thank you! looks good, builds and works for me. i was thinking about this way of fixing the original issue but i was still hoping that there is a way to gracefully share the logic with the frame-opacity option fix. merging this fixes the #997 and we need to ask folks from the #808 if this also fixes their issue since their issue seems different.

Force the temporary picture to a 32-bit ARGB visual when masking it for
rounded corners to keep the transparency information. Otherwise, windows
with a 24-bit visual would get black corners instead.

Authored-by: Bernd Busse <[email protected]>
Signed-off-by: Yuxuan Shui <[email protected]>
@yshui yshui merged commit 70ea36b into yshui:next Dec 19, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants