Hopefully fix ex_uri - related build issues for everybody #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: rebar.config
…ndency of a larger rebar application
|
@ferd, what do you think? |
|
Haven't had the time to check it yet. On Mon, Sep 19, 2011 at 2:37 PM, Yurii Rashkovskii <
|
|
Any progress with this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a (hopefully more straightforward) fix to issue #61 (failure to find ex_uri.hrl).
The change gets rid of the macro definition in rebar.conf and adds a couple of include dirs that satisfy various build environments. Also reverts socketio_listener to previous state.
I have tested this with make and rebar get-deps ; rebar compile on a fresh clone of my fork, as well as by including it as a dependency in my rebar-based app. Should work for everybody, but it won't hurt to try before pulling it in.