Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GHA triggers #2

Merged
merged 2 commits into from
May 16, 2024
Merged

Update GHA triggers #2

merged 2 commits into from
May 16, 2024

Conversation

isarkis
Copy link
Member

@isarkis isarkis commented May 16, 2024

Run workflows on push, pull_request, and workflow_dispatch (manual trigger).

b/336560952

@isarkis
Update GHA triggers
c06632d 
Run workflows on push, pull_request, and workflow_dispatch (manual trigger).

b/336560952
@isarkis
Update docker-build.yml
2c7bacd
@isarkis isarkis merged commit 2f272b6 into dev_workflows May 16, 2024
3 checks passed
@isarkis isarkis deleted the isarkis-patch-1 branch May 16, 2024 16:28
kaidokert pushed a commit that referenced this pull request May 18, 2024
Incrementing VERSION to 120.0.6099.1
8e2ae80 
Change-Id: Ia66ab5b540e4b4edb401ac986834128a0c7bccdf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4987652
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6099@{#2}
Cr-Branched-From: e6ee450-refs/heads/main@{#1217362}
kaidokert pushed a commit that referenced this pull request May 18, 2024
Incrementing VERSION to 126.0.6478.1
278b984 
Change-Id: I3d4d1a62bdbad9dafd932c85abf43db3a2003972
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5533809
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6478@{#2}
Cr-Branched-From: e6143ac-refs/heads/main@{#1300313}
kaidokert pushed a commit that referenced this pull request May 18, 2024
@schwering
[Autofill] Refactor BAM::GetProfileSuggestions() #2
ba01647 
This CL removes a special case in GetProfileSuggestions() and treats
it in the helper lambdas instead.

This eliminates an implicit relationship between a IsAddressType()
and a NOTREACHED_NORETURN().

It also leaves two TODOs to check if this special case was correct.
A followup CL attempts to remove them.

This CL preserves equivalence.

Bug: 339543182
Change-Id: I47d8bc612660e4ba6295d44bab59c05bffef6141
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5538227
Reviewed-by: Jihad Hanna <[email protected]>
Code-Coverage: [email protected] <[email protected]>
Commit-Queue: Christoph Schwering <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1302811}
kaidokert pushed a commit that referenced this pull request May 22, 2024
@zetafunction
Disable GPU in capture tests in MSan
de85918 
Attempting to initialize the GPU triggers MSan failures in GL with eager
checks enabled in MSan:

Uninitialized bytes in strlen at offset 0 inside [0x70200013dec0, 30)
==589==WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x7fffeeba96de in glLabelObjectEXT (/lib/x86_64-linux-gnu/libGLX_mesa.so.0+0x4f6de)
    #1 0x7fffeeba9b10 in glLabelObjectEXT (/lib/x86_64-linux-gnu/libGLX_mesa.so.0+0x4fb10)
    #2 0x7fffeeb879a3  (/lib/x86_64-linux-gnu/libGLX_mesa.so.0+0x2d9a3)
    #3 0x7fffeeb894c0  (/lib/x86_64-linux-gnu/libGLX_mesa.so.0+0x2f4c0)
    #4 0x7fffeeb8e400  (/lib/x86_64-linux-gnu/libGLX_mesa.so.0+0x34400)
    chromium#5 0x7fffeeb8f384  (/lib/x86_64-linux-gnu/libGLX_mesa.so.0+0x35384)
    chromium#6 0x7fffeeb8bd9a  (/lib/x86_64-linux-gnu/libGLX_mesa.so.0+0x31d9a)
    chromium#7 0x7fffecceb484 in queryExtensionsString third_party/angle/src/libANGLE/renderer/gl/glx/FunctionsGLX.cpp:354:12
    chromium#8 0x7fffecceb484 in rx::FunctionsGLX::initialize(_XDisplay*, int, std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>*) third_party/angle/src/libANGLE/renderer/gl/glx/FunctionsGLX.cpp:223:30
    chromium#9 0x7fffeccdada2 in rx::DisplayGLX::initialize(egl::Display*) third_party/angle/src/libANGLE/renderer/gl/glx/DisplayGLX.cpp:114:15
    chromium#10 0x7fffec70f649 in egl::Display::initialize() third_party/angle/src/libANGLE/Display.cpp:1082:36
    chromium#11 0x7fffec0bed17 in egl::Initialize(egl::Thread*, egl::Display*, int*, int*) third_party/angle/src/libGLESv2/egl_stubs.cpp:514:5
    chromium#12 0x7fffec0c6319 in EGL_Initialize third_party/angle/src/libGLESv2/entry_points_egl_autogen.cpp:571:27
    chromium#13 0x7fffefc4000d in eglInitialize third_party/angle/src/libEGL/libEGL_autogen.cpp:177:12
    chromium#14 0x5555868ec92a in gl::GLDisplayEGL::InitializeDisplay(bool, std::__Cr::vector<gl::DisplayType, std::__Cr::allocator<gl::DisplayType>>, gl::EGLDisplayPlatform, gl::GLDisplayEGL*) ui/gl/gl_display.cc:769:10
    chromium#15 0x5555868eb310 in gl::GLDisplayEGL::Initialize(bool, std::__Cr::vector<gl::DisplayType, std::__Cr::allocator<gl::DisplayType>>, gl::EGLDisplayPlatform) ui/gl/gl_display.cc:660:8
    chromium#16 0x55556c6f1957 in ui::GLOzoneEGL::InitializeGLOneOffPlatform(bool, std::__Cr::vector<gl::DisplayType, std::__Cr::allocator<gl::DisplayType>>, gl::GpuPreference) ui/ozone/common/gl_ozone_egl.cc:25:17
    chromium#17 0x55558b1a8999 in gl::init::InitializeGLOneOffPlatform(gl::GpuPreference) ui/gl/init/gl_initializer_ozone.cc:27:26
    chromium#18 0x55558b1a6978 in gl::init::InitializeGLOneOffPlatformImplementation(bool, bool, bool, gl::GpuPreference) ui/gl/init/gl_factory.cc:211:24
    chromium#19 0x55558b1a6208 in gl::init::(anonymous namespace)::InitializeGLOneOffPlatformHelper(bool, gl::GpuPreference) ui/gl/init/gl_factory.cc:135:10
    chromium#20 0x55558b1a662d in gl::init::InitializeGLNoExtensionsOneOff(bool, gl::GpuPreference) ui/gl/init/gl_factory.cc:166:10
    chromium#21 0x55558b227379 in gpu::GpuInit::InitializeAndStartSandbox(base::CommandLine*, gpu::GpuPreferences const&) gpu/ipc/service/gpu_init.cc:495:18
    chromium#22 0x55559ab41ce4 in content::GpuMain(content::MainFunctionParams) content/gpu/gpu_main.cc:358:39
    chromium#23 0x55557b5888da in content::RunZygote(content::ContentMainDelegate*) content/app/content_main_runner_impl.cc:685:14
    chromium#24 0x55557b58abad in content::RunOtherNamedProcessTypeMain(std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> const&, content::MainFunctionParams, content::ContentMainDelegate*) content/app/content_main_runner_impl.cc:789:12
    chromium#25 0x55557b58e4fe in content::ContentMainRunnerImpl::Run() content/app/content_main_runner_impl.cc:1156:10
    chromium#26 0x55557b585aaf in content::RunContentProcess(content::ContentMainParams, content::ContentMainRunner*) content/app/content_main.cc:332:36
    chromium#27 0x55557b58644a in content::ContentMain(content::ContentMainParams) content/app/content_main.cc:345:10
    chromium#28 0x555580df9c37 in content::LaunchTestsInternal(content::TestLauncherDelegate*, unsigned long, int, char**) content/public/test/test_launcher.cc:385:12
    chromium#29 0x555580dfab58 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) content/public/test/test_launcher.cc:504:10
    chromium#30 0x555582b8afec in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) chrome/test/base/chrome_test_launcher.cc:392:10
    chromium#31 0x55557d422a0e in main chrome/test/base/browser_tests_main.cc:60:10
    chromium#32 0x7ffff48456c9 in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
    chromium#33 0x7ffff4845784 in __libc_start_main csu/../csu/libc-start.c:360:3
    chromium#34 0x55555e647029 in _start (/usr/local/google/home/dcheng/src/chrome/src/out/msan/browser_tests+0x90f3029) (BuildId: 6cbc295b16ac1107)

  Uninitialized value was created by a heap allocation
    #0 0x55555e675a22 in malloc /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cpp:1021:3
    #1 0x7ffff489b087 in __vasprintf_internal libio/vasprintf.c:116:16
    #2 0x4ae8d349882b18ff  (<unknown module>)

Bug: 40240570
Change-Id: If59faa297e214b7219ebb4c5c9572b44a33ee070
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5548826
Reviewed-by: Elad Alon <[email protected]>
Commit-Queue: Daniel Cheng <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1303583}
kaidokert pushed a commit that referenced this pull request May 22, 2024
@zetafunction
Initialize floss:BluetoothLocalGattDescriptorFloss::cccd_type_
bac7f6c 
BluetoothLowEnergyApiTestChromeOs.NotifyCharacteristicValueChanged fails
when run in MSan mode with eager checks, which validates that uninit
values are not passed as params or return values:

==1002568==WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x561d07debefa in floss::BluetoothLocalGattCharacteristicFloss::CccdNotificationType() ./../../device/bluetooth/floss/bluetooth_local_gatt_characteristic_floss.cc:398:1
    #1 0x561d07daf88b in floss::BluetoothAdapterFloss::SendValueChanged(floss::BluetoothLocalGattCharacteristicFloss*, std::__Cr::vector<unsigned char, std::__Cr::allocator<unsigned char>> const&) ./../../device/bluetooth/floss/bluetooth_adapter_floss.cc:1468:23
    #2 0x561d07de5eb7 in floss::BluetoothLocalGattCharacteristicFloss::NotifyValueChanged(device::BluetoothDevice const*, std::__Cr::vector<unsigned char, std::__Cr::allocator<unsigned char>> const&, bool) ./../../device/bluetooth/floss/bluetooth_local_gatt_characteristic_floss.cc:104:34
    #3 0x561cf920f095 in extensions::api::BluetoothLowEnergyNotifyCharacteristicValueChangedFunction::DoWork() ./../../extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_api.cc:1427:23
  <...>

  Uninitialized value was created by a heap allocation
    #0 0x561cdea7d49c in operator new(unsigned long) /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/msan/msan_new_delete.cpp:51:35
    #1 0x561d07dede02 in floss::BluetoothLocalGattDescriptorFloss::Create(device::BluetoothUUID const&, unsigned int, floss::BluetoothLocalGattCharacteristicFloss*) ./../../device/bluetooth/floss/bluetooth_local_gatt_descriptor_floss.cc:26:22
    #2 0x561d07de4ce6 in floss::BluetoothLocalGattCharacteristicFloss::Create(device::BluetoothUUID const&, unsigned int, unsigned int, floss::BluetoothLocalGattServiceFloss*) ./../../device/bluetooth/floss/bluetooth_local_gatt_characteristic_floss.cc:35:5
    #3 0x561d07df5fec in floss::BluetoothLocalGattServiceFloss::CreateCharacteristic(device::BluetoothUUID const&, unsigned int, unsigned int) ./../../device/bluetooth/floss/bluetooth_local_gatt_service_floss.cc:142:10
    #4 0x561cf920c91f in extensions::api::BluetoothLowEnergyCreateCharacteristicFunction::DoWork() ./../../extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_api.cc:1310:16

Bug: 40240570
Change-Id: I3dd8d46b5750bc881ada08560943151dac294c08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5553870
Reviewed-by: Katherine Lai <[email protected]>
Commit-Queue: Daniel Cheng <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1303901}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@isarkis