Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SnackBar 구현 #14

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

SnackBar 구현 #14

wants to merge 15 commits into from

Conversation

leeeyubin
Copy link
Member

@leeeyubin leeeyubin commented Sep 23, 2024

SnackBar 구현했습니다.

image

SnackBar를 띄우는 과정이 고민인데 Scaffold를 직접 구현해서 사용한다면 편리할 것 같다는 생각이 드네요..

띄우는 방법은 Popup 속성을 사용해서 다이얼로그처럼 스낵바를 띄우도록 구현해놓았습니다.
더 괜찮은 방법이 있다면 조언부탁드림니다

Screen_Recording_20240922_112253_Handy-Android.mp4

@leeeyubin leeeyubin added the enhancement New feature or request label Sep 23, 2024
@leeeyubin leeeyubin self-assigned this Sep 23, 2024
Copy link
Member

@kangyuri1114 kangyuri1114 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 수정사항이 있어서 확인 부탁드려요!

) {
Column(
modifier = modifier
.padding(horizontal = 16.dp)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

padding 이 두번 들어간 것 같습니다!

) {
Row(
modifier = modifier
.padding(horizontal = 16.dp)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기 padding도용

@Composable
fun InfoSnackBar(
text: String,
onDismiss: () -> Unit,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

snackbar 변경사항

스낵바가 이후에 수정되어서 onDIsmiss(여백 클릭 시)옵션이 사라지고 스와이프 시에 없어지는 것으로 바뀌었어요! 스와이프 이벤트도 만들어주셔야 할 것 같아요!!

compose/src/main/res/drawable/ic_alert_triangle.xml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants