Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync fork #1

Merged
merged 33 commits into from
Feb 14, 2025
Merged

Sync fork #1

merged 33 commits into from
Feb 14, 2025

Conversation

youngyjd
Copy link
Owner

Merge from main

puchengy and others added 30 commits February 4, 2025 19:28
…nts from gravitino-env.sh (apache#6385)

<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
   Examples:
     - "[apache#123] feat(operator): support xxx"
     - "[apache#233] fix: check null before access result in xxx"
     - "[MINOR] refactor: fix typo in variable name"
     - "[MINOR] docs: fix typo in README"
     - "[apache#255] test: fix flaky test NameOfTheTest"
   Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. If the PR is unfinished, please mark this PR as draft.
-->

### What changes were proposed in this pull request?

Update Gravitino JVM memory default.

### Why are the changes needed?

Fix: apache#6384

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

No test
…ig files and open-file flag test cases (apache#6280)

### What changes were proposed in this pull request?

Add gvfs-fuse integration tests for big files and open-file flag test
cases

### Why are the changes needed?

Fix: apache#6279

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

IT
…ete...limit..` clause. (apache#6393)

### What changes were proposed in this pull request?

PostgreSQL does not support SQL sentences like `DELETE FROM xxxx_table
where xxxx limit 10` , Cluase `limit xxx` is not allowed in the `Delete
syntax`

### Why are the changes needed?

it's a bug.

Fix: apache#6380 

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

UT
…6360)

### What changes were proposed in this pull request?

 Add tag support for model in CLI.

1. `UntagEntity`
2. `TagEntity`
3. `ListEntityTags`

The logic for handling models in these three methods has been added.
need to add the processing logic to the `RemoveAllTags` method.

### Why are the changes needed?

Fix: apache#6356 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

local test.
…ng (apache#6398)

### What changes were proposed in this pull request?

Improve the gvfs to expose the nested exception for better
understanding.

### Why are the changes needed?

The exception message may not be enough to understand the problem why
the fs initialization is failed. So we should expose the whole stack for
better understanding.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Existing tests.
…void conflict with authorization module (apache#6376)

### What changes were proposed in this pull request?

Remove jar `protobuf-java.jar` from the distribution package to avoid
conflicts

### Why are the changes needed?

To make authorization works for GCS fileset.

Fix: apache#6375 

### Does this PR introduce _any_ user-facing change?

N/A.

### How was this patch tested?

N/A
…6.1 (apache#6374)

### What changes were proposed in this pull request?

Upgrade Iceberg version from 1.5.2 to 1.6.1

In 1.6, the `token` endpoint is deprecated and there're no new endpoint
is added.


### Why are the changes needed?

Fix: apache#6394 

### Does this PR introduce _any_ user-facing change?
no

### How was this patch tested?
run pass existing ITs
…gvfs-fuse command line tools (apache#6321)

### What changes were proposed in this pull request?

1. Support mount and umount command
2. Make mount create a daemon process to run background


### Why are the changes needed?

Fix: apache#6320 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

IT

---------

Co-authored-by: Qiming Teng <[email protected]>
…esystem::stat() to improve the performance of open_dal_filesystem (apache#6358)

### What changes were proposed in this pull request?

Passing file type argument in the Filesystem::stat() to improve the
performance of open_dal_filesystem

### Why are the changes needed?

Fix: apache#6357 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

UI

---------

Co-authored-by: Qiming Teng <[email protected]>
### What changes were proposed in this pull request?

Refactor to add a command context and simple wrappers on output to make
it easy for "global" command like a "--quiet" option to be added.

Note this in progress as this only has changed Metlake. Some duplicate
code can be removed once everything is done.

### Why are the changes needed?

For maintainability.

Fix: apache#6326

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Tested locally.

---------

Co-authored-by: Shaofeng Shi <[email protected]>
…pache#6408)

### What changes were proposed in this pull request?

Move the `Fileset` and `Model` related classes to the sub-package for
better organized.

### Why are the changes needed?

For better organized.

Fix: apache#6407 

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Existing tests.
…pache#5980)

### What changes were proposed in this pull request?

Implemented pre-event handling for all tag-related operations,
including:

- listTags
- listTagsInfo
- getTag
- createTag
- alterTag
- deleteTag
- listMetadataObjectsForTag
- listTagsForMetadataObject
- listTagsInfoForMetadataObject
- associateTagsForMetadataObject
- getTagForMetadataObject

### Why are the changes needed?
Fix: apache#5900

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
add UT
…the return value of fileset catalog (apache#6410)

### What changes were proposed in this pull request?

This PR changes the return value to `GenericFileset` for fileset
operation.

### Why are the changes needed?

Previously, it returns the plain fileset dto, so that it cannot support
some operations like get credentials.

Fix: apache#6409 

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Existing tests.
…ache#6359)

### What changes were proposed in this pull request?

Fix the CLI  delete the anonymous user
### Why are the changes needed?

Fix: apache#5932 

### Does this PR introduce _any_ user-facing change?

(Please list the user-facing changes introduced by your change,
including
  1. Change in user-facing APIs.
  2. Addition or removal of property keys.)

### How was this patch tested?

local test

```bash
gcli user delete -m demo_metalake --user anonymous
# Can't delete anonymous user. This will cause unexpected behavior.
```

<img width="536" alt="image"
src="https://github.com/user-attachments/assets/479ec7eb-2ad3-42bd-b70a-a6f2ce05f794"
/>
### What changes were proposed in this pull request?

Add table command context CLI.

### Why are the changes needed?

Fix: apache#6419 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

local test.
)

### What changes were proposed in this pull request?

Add Fileset command context CLI

### Why are the changes needed?

Fix: apache#6415 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

local test
### What changes were proposed in this pull request?

Add model command context CLI

### Why are the changes needed?

Fix: apache#6417 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

local test
### What changes were proposed in this pull request?

Add schema command context CLI

### Why are the changes needed?

Fix: apache#6416 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

local test.
)

### What changes were proposed in this pull request?

Add catalog command context CLI

### Why are the changes needed?

Fix: apache#6414 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

local test.
### What changes were proposed in this pull request?

Add stream command context CLI

### Why are the changes needed?

Fix: apache#6418 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

local test.
### What changes were proposed in this pull request?

Add column command context CLI

### Why are the changes needed?

Fix: apache#6420 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

local test.
…iew.md` (apache#6439)

### What changes were proposed in this pull request?
This PR fixes the description of the `Multi-engine support` section in
`overview.md`, as Gravitino now supports connectors for Apache Spark and
Apache Flink.

### Why are the changes needed?
Gravitino now supports connectors for Apache Spark and Apache Flink.


### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
manual review
### What changes were proposed in this pull request?

Add tags command context CLI

### Why are the changes needed?

Fix: apache#6423 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

local test
…pache#6437)

### What changes were proposed in this pull request?

 Add user and group command context CLI

### Why are the changes needed?

Fix: apache#6421

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

local test.
…pache#6438)

### What changes were proposed in this pull request?

Add roles and owner command context CLI

### Why are the changes needed?

Fix: apache#6422 

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

local test.
… simple commands. (apache#6440)

### What changes were proposed in this pull request?

Refactor getURL in CLI and add context to simple commands.

### Why are the changes needed?

Fix: apache#6424 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

local test.
### What changes were proposed in this pull request?

The PR updates incorrect log format codes from `%s` to `{}` in the
following lines:

- Line 420
- Line 483
- Line 504
- Line 525

The original code in these lines used the `%s` placeholder, which is
invalid for the logging framework used. It has been corrected to use
`{}` to match the proper syntax for log messages.

### Why are the changes needed?

This change is necessary to fix the incorrect log format codes in the
codebase. The `%s` placeholder is not valid and can lead to incorrect
log formatting or errors when the logs are generated. The correct
placeholder syntax for this logging framework is `{}`.

Fix: apache#6429

### Does this PR introduce _any_ user-facing change?

No user-facing changes are introduced. This is an internal fix for the
logging format.

### How was this patch tested?

The changes were verified manually by reviewing the code and ensuring
that all instances of `%s` were replaced with `{}` in the affected
lines. No new functionality was added, so no additional tests were
required.
…ate paimon table by flink (apache#6362)

### What changes were proposed in this pull request?

Support specifying primary keys during create paimon table by flink

### Why are the changes needed?


Fix: apache#6361 

### Does this PR introduce _any_ user-facing change?

None

### How was this patch tested?

Add testCreateTableWithPrimaryKey case in
org.apache.gravitino.flink.connector.integration.test.FlinkCommonIT
### What changes were proposed in this pull request?

multi catalog and view operation should shown in document side bars.

### Why are the changes needed?
User could find multi catalog configuration easily

### Does this PR introduce _any_ user-facing change?
no

### How was this patch tested?
just document
### What changes were proposed in this pull request?

Remove redundant code in CLI, and make context argument final in Command
class.

### Why are the changes needed?

The constructor should take only one argument, CommandContext.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

local test.
Abyss-lord and others added 3 commits February 13, 2025 19:10
…pache#6447)

### What changes were proposed in this pull request?

Add --quiet option to the Gravitino CLI

### Why are the changes needed?

Fix: apache#6097 

### Does this PR introduce _any_ user-facing change?

user can use --quiet option suppress the output.

### How was this patch tested?

local test

```bash
gcli tag create -m cli_demo --tag tagA tagB -i
# Tags tagA,tagB created

gcli tag create -m cli_demo --tag tagC tagD -i --quiet
# no output
```
### What changes were proposed in this pull request?

Refactor getAuth method in CLI.

### Why are the changes needed?

Fix: apache#6449

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

local test.
### What changes were proposed in this pull request?
authentication.type of catalog property should send correct request to
server

### Why are the changes needed?
N/A

Fix: apache#6450

### Does this PR introduce _any_ user-facing change?
N/A

### How was this patch tested?
manually
@youngyjd youngyjd merged commit f36c13f into main Feb 14, 2025
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.