Skip to content
This repository has been archived by the owner on Oct 13, 2020. It is now read-only.

[feat] Masonry component with just url image, need to pass image path #49

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

aupous
Copy link

@aupous aupous commented Feb 14, 2019

Closes #30

@aupous aupous requested a review from hieuhani February 14, 2019 17:16
@codecov-io
Copy link

codecov-io commented Feb 15, 2019

Codecov Report

Merging #49 into master will decrease coverage by 0.88%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #49      +/-   ##
=========================================
- Coverage    5.57%   4.69%   -0.89%     
=========================================
  Files          17      18       +1     
  Lines         233     277      +44     
  Branches       21      24       +3     
=========================================
  Hits           13      13              
- Misses        220     264      +44
Impacted Files Coverage Δ
packages/react-silk-ui/src/components/Masonry.tsx 0% <0%> (ø)
packages/react-silk-ui/src/index.ts 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7b1396...4166875. Read the comment docs.

Copy link
Contributor

@hieuhani hieuhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aupous vào xem comment nhé

packages/react-silk-docs/src/pages/components/masonry.tsx Outdated Show resolved Hide resolved
packages/react-silk-docs/src/pages/components/masonry.tsx Outdated Show resolved Hide resolved
packages/react-silk-docs/src/pages/components/masonry.tsx Outdated Show resolved Hide resolved
packages/react-silk-docs/src/pages/components/masonry.tsx Outdated Show resolved Hide resolved
packages/react-silk-ui/src/components/Masonry.tsx Outdated Show resolved Hide resolved
packages/react-silk-ui/src/components/Masonry.tsx Outdated Show resolved Hide resolved
packages/react-silk-ui/src/components/Masonry.tsx Outdated Show resolved Hide resolved
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants