Broadcast and render block selection #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
force-pushed
the
update/broadcast-and-render-block-selection
branch
from
df35335 to
cc55156
Compare
|
This is still not perfect in terms of UI (no colors...) but It's a nice refactor to the sync hook, I'm merging it that way for now and let's iterate on the UI. In parallel, I'll be exploring merging this hook with the yjs branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #4
This PR works in conjunction with this PR youknowriad/asblocks-collab#3
It mostly works and adds a dashed border around the blocks selected by other peers.
That said, I noticed bugs in the synchronization and caret jumps. I'm not sure yet it's related but worth testing properly and solving these bugs first.