Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI-474: Extracted RadioGroup style component #409

Merged
merged 3 commits into from
Sep 30, 2024
Merged

UI-474: Extracted RadioGroup style component #409

merged 3 commits into from
Sep 30, 2024

Conversation

mosarabi
Copy link
Contributor

@mosarabi mosarabi commented Sep 23, 2024

JIRA Ticket

UI-474

QA Steps

  • 1. Navigate to Storybook: Ensure the component is properly set up and viewable in the Storybook environment.

  • 2. Check for Visual Regressions: Thoroughly examine the component's visual appearance and behavior to identify any regressions or unexpected changes compared to the expected state.

  • 3. Verify Right-to-Left (RTL) Layout: Test the component's layout and functionality when rendered in a right-to-left direction to ensure it adapts and functions correctly.

  • 4. Verify Responsiveness: Test the component's layout and behavior across different screen sizes and devices to ensure it adapts and functions correctly.

  • 5. Inspect Class Names: Ensure the component's CSS class names are specific and follow the project's naming conventions to maintain code maintainability and consistency.

  • 6. Perform Build Checks: Build the application and check for any errors or warnings to catch any issues that may prevent successful deployment.

Note

Leave empty when you have nothing to say

@mosarabi mosarabi added the 💻 Ready for review Requires a review from another developer. label Sep 23, 2024
@mosarabi mosarabi self-assigned this Sep 23, 2024
Copy link

github-actions bot commented Sep 23, 2024

🔍 Visual review for your branch is published 🔍

Here are the links to:

@GhitaNektt GhitaNektt added ✅ Reviewed PR has been reviewed and approved. and removed 💻 Ready for review Requires a review from another developer. labels Sep 30, 2024
@mosarabi mosarabi merged commit c7070e4 into main Sep 30, 2024
2 checks passed
@mosarabi mosarabi deleted the UI-474 branch September 30, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Reviewed PR has been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants