Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI-433: Removed defineAsyncComponent and Use Component Directly #384

Merged
merged 2 commits into from
Jul 5, 2024
Merged

UI-433: Removed defineAsyncComponent and Use Component Directly #384

merged 2 commits into from
Jul 5, 2024

Conversation

mosarabi
Copy link
Contributor

@mosarabi mosarabi commented Jul 4, 2024 •
edited by jira bot
Loading

JIRA Ticket

UI-433

QA Steps

  • RTL
  • Responsiveness
  • Class Names (insure specificity)
  • Build (No errors)

Note

Leave empty when you have nothing to say

@mosarabi mosarabi added the 💻 Ready for review Requires a review from another developer. label Jul 4, 2024
@mosarabi mosarabi self-assigned this Jul 4, 2024
@GhitaNektt GhitaNektt added ✅ Reviewed PR has been reviewed and approved. and removed 💻 Ready for review Requires a review from another developer. labels Jul 5, 2024
@mosarabi mosarabi merged commit 96bf176 into main Jul 5, 2024
3 checks passed
@mosarabi mosarabi deleted the UI-433 branch July 5, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GhitaNektt GhitaNektt GhitaNektt approved these changes

@eihabkhan1 eihabkhan1 Awaiting requested review from eihabkhan1 eihabkhan1 is a code owner

Assignees

@mosarabi mosarabi

Labels
✅ Reviewed PR has been reviewed and approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mosarabi @GhitaNektt