YSHOP2-1216: Added DropdownMenu component #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GhitaNektt
requested review from
AliHMIMS,
mosarabi and
eihabkhan1
as code owners
-m "Merged main to resolve conflicts"
GhitaNektt
added
💻 Ready for review
eihabkhan1
reviewed
Jan 25, 2024
|
|
||
| const show = ref(false); | ||
| const DropdownMenu = ref(); | ||
| const toggleMenu = () => { |
There was a problem hiding this comment.
Always separate refs from others
added 3 commits
January 25, 2024 16:38
-m "Merged main to resolve conflicts"
GhitaNektt
added
⏳ in progress
added 3 commits
January 26, 2024 10:38
-m "Merged main to update branch"
mosarabi
requested changes
Jan 29, 2024
| }); | ||
| }; | ||
|
|
||
| onClickOutside(DropdownMenuContainer, () => show.value = false); |
There was a problem hiding this comment.
Suggested change
| onClickOutside(DropdownMenuContainer, () => show.value = false); | |
| const handleScroll = () => { | |
| show.value = false; | |
| }; | |
| onMounted(() => { | |
| window.addEventListener('scroll', handleScroll); | |
| }); | |
| onUnmounted(() => { | |
| window.removeEventListener('scroll', handleScroll); | |
| }); | |
| onClickOutside(DropdownMenuContainer, () => show.value = false); |
There was a problem hiding this comment.
Would you mind to add scroll event to hide menu when user start scrolling
| @@ -0,0 +1,85 @@ | |||
| <script setup lang="ts"> | |||
| import { nextTick, ref } from 'vue'; | |||
There was a problem hiding this comment.
Suggested change
| import { nextTick, ref } from 'vue'; | |
| import { nextTick, ref, onMounted, onUnmounted } from 'vue'; |
mosarabi
requested changes
Jan 29, 2024
| max-width: 100%; | ||
| margin: 0; | ||
| } | ||
| </style> |
There was a problem hiding this comment.
I think no need to create this component
What d u think?
mosarabi
approved these changes
Jan 29, 2024
|
Can we set the cursor to pointer on the items |
yeah sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket
YSHOP2-1216
QA Steps
Note
Leave empty when you have nothing to say