changed LambdaFilter/LambdaTokenizer phpdoc param from function to callable #70
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I am using your library for some time and I think it is great!
But, every time I pass a callable in LambdaFilter, psalm and phpstorm arguing at me that I'm using an invalid argument like this:
ERROR: InvalidArgument - scripts/Namespace/VO/SomeVO.php:42:52 - Argument 1 of TextAnalysis\Filters\LambdaFilter::__construct expects TextAnalysis\Filters\function, pure-Closure(mixed):(null|string) provided (see https://psalm.dev/004) ->applyTransformation(new LambdaFilter(static function (string $word) { return preg_replace(self::AVAILABLE_CHARACTERS_REGEXP, '', $word); }));
Maybe it would be better to have
callable
phpdoc, because it doesn't lead to any errors?