feat: llm-sfn don't return an error if it don't read arguments #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #846 +/- ##
==========================================
- Coverage 64.93% 64.64% -0.30%
==========================================
Files 45 45
Lines 2658 2650 -8
==========================================
- Hits 1726 1713 -13
- Misses 820 824 +4
- Partials 112 113 +1 ☔ View full report in Codecov by Sentry. |
venjiang
approved these changes
Jun 27, 2024
fanweixiao
approved these changes
Jun 28, 2024
| @@ -281,6 +281,6 @@ func checkLLMFunctionCall(logger *slog.Logger, serverlessCtx yserverless.Context | |||
| return | |||
| } | |||
| if !fc.IsOK { | |||
| logger.Warn("The function return nothing to LLM, please ensure ctx.ReadLLMArguments() and ctx.WriteLLMResult() has been called in Handler func.") | |||
| logger.Warn("The function return nothing to LLM, please ensure ctx.WriteLLMResult() has been called and successful in Handler func.") | |||
There was a problem hiding this comment.
Suggested change
| logger.Warn("The function return nothing to LLM, please ensure ctx.WriteLLMResult() has been called and successful in Handler func.") | |
| logger.Warn("Function did not return any LLM result, ensure ctx.WriteLLMResult() is called and successful in the Handler function.") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.