Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dict moving faster and save scroll location #1671

Merged
merged 4 commits into from
Dec 17, 2024

Conversation

Kuuuube
Copy link
Member

@Kuuuube Kuuuube commented Dec 16, 2024

Somewhat of a fix for #1092.

Adds a stripped down synchronous version of _updateEntries that also resets the scroll position.

Moving dicts doesn't require all of what _updateEntries uses since the number of dicts, dict names, dict contents, etc should never be changed in a move.

Intentionally not adding the scroll position reset to _updateEntries since during other operations there can be other errors that the user needs to see at the top of the modal body.

@Kuuuube Kuuuube added kind/enhancement The issue or PR is a new feature or request area/performance The issue or PR is related to performance area/ui-ux The issue or PR is related to UI/UX/Design labels Dec 16, 2024
@Kuuuube Kuuuube requested a review from a team as a code owner December 16, 2024 22:53
Copy link

github-actions bot commented Dec 16, 2024

Playwright test results

failed  2 failed
passed  3 passed

Details

stats  5 tests across 4 suites
duration  8 minutes, 33 seconds
commit  f3dff02

Failed tests

chromium › integration.spec.js › anki add
chromium › visual.spec.js › visual

jamesmaa
jamesmaa previously approved these changes Dec 17, 2024
Copy link

codspeed-hq bot commented Dec 17, 2024

CodSpeed Performance Report

Merging #1671 will not alter performance

Comparing Kuuuube:better-dict-moving (638ff02) with master (68a5979)

Summary

✅ 3 untouched benchmarks

@jamesmaa jamesmaa added this pull request to the merge queue Dec 17, 2024
Merged via the queue into yomidevs:master with commit f3dff02 Dec 17, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/performance The issue or PR is related to performance area/ui-ux The issue or PR is related to UI/UX/Design kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants