Make dict moving faster and save scroll location #1671
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somewhat of a fix for #1092.
Adds a stripped down synchronous version of
_updateEntries
that also resets the scroll position.Moving dicts doesn't require all of what
_updateEntries
uses since the number of dicts, dict names, dict contents, etc should never be changed in a move.Intentionally not adding the scroll position reset to
_updateEntries
since during other operations there can be other errors that the user needs to see at the top of the modal body.