Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add average frequency tag #1479

Merged
merged 27 commits into from
Feb 24, 2025
Merged

add average frequency tag #1479

merged 27 commits into from
Feb 24, 2025

Conversation

tadorituki
Copy link

this is a draft.
added a tag that displays the harmonic mean of the frequency ranks
updated a few things from #1303

Copy link

codspeed-hq bot commented Oct 12, 2024

CodSpeed Performance Report

Merging #1479 will not alter performance

Comparing tadorituki:tadoru (736dbcd) with master (4f109a9)

Summary

✅ 5 untouched benchmarks

@tadorituki tadorituki marked this pull request as ready for review October 13, 2024 02:56
@tadorituki tadorituki requested a review from a team as a code owner October 13, 2024 02:56
@tadorituki
Copy link
Author

this is ready for merge, please review

Copy link

github-actions bot commented Oct 14, 2024

@tadorituki tadorituki marked this pull request as draft October 14, 2024 18:14
@tadorituki tadorituki marked this pull request as ready for review October 14, 2024 20:13
@tadorituki
Copy link
Author

fixed issues with unit tests, now ready to merge

Copy link
Member

@Kuuuube Kuuuube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kuuuube
Copy link
Member

Kuuuube commented Oct 15, 2024

It's probably also a good idea to split out the average calculation from the groupTermFrequencies function. Maybe just have a call to a different function inside the groupTermFrequencies that adds on to the data or whatever it needs to do.

@Kuuuube Kuuuube added kind/enhancement The issue or PR is a new feature or request area/ui-ux The issue or PR is related to UI/UX/Design labels Nov 6, 2024
@djahandarie
Copy link
Collaborator

@tadorituki Do you have time to make changes to get this merged?

@tadorituki
Copy link
Author

ready to merge. i think

@djahandarie djahandarie requested a review from Kuuuube February 24, 2025 09:07
Copy link
Member

@Kuuuube Kuuuube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some refactoring of this myself. This should be good now.

@Kuuuube
Copy link
Member

Kuuuube commented Feb 24, 2025

Since I'm the last committer, I cannot merge this myself. Will need another approval.

@Casheeew Casheeew added this pull request to the merge queue Feb 24, 2025
Merged via the queue into yomidevs:master with commit 0357e8f Feb 24, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-ux The issue or PR is related to UI/UX/Design kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants