-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add average frequency tag #1479
Conversation
CodSpeed Performance ReportMerging #1479 will not alter performanceComparing Summary
|
this is ready for merge, please review |
fixed issues with unit tests, now ready to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a settings update for this here: https://github.com/yomidevs/yomitan/blob/master/ext/js/data/options-util.js
And bump the version here: https://github.com/yomidevs/yomitan/blob/master/test/options-util.test.js
It's probably also a good idea to split out the average calculation from the |
@tadorituki Do you have time to make changes to get this merged? |
ready to merge. i think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did some refactoring of this myself. This should be good now.
Since I'm the last committer, I cannot merge this myself. Will need another approval. |
this is a draft.
added a tag that displays the harmonic mean of the frequency ranks
updated a few things from #1303