[pull] master from emacs-helm:master #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
helm-completion--decorate returns COMPS unmodified when afun afix and category are nil and helm-completion-in-region-default-sort-fn returns as well its candidates unmodified if sorting is already done.
Rewrite and simplify helm-completion--multi-all-completions-1 by using completion-regexp-list.
This reverts commit b6f3a0c.
This is done for the helm style fn but seems the same problem happens with flex adjust metadata fn.
This reverts commit 4dd19c9.
This happen with adb method.
update docstring.
There is now packages installing other packages asynchronously (even helm now has its package manager async), so this mode is clashing with such packages. Also heavy modifications in helm-core are less frequent nowaday (macro renaming etc..).
Magit is disabling sorting in its `magit-completing-read-multiple' by let binding `helm-completion-in-region-default-sort-fn' to nil to prevent modifying candidates order.
This allow skiping dst *acase branchs (return nil) that don't fit with cl-destructuring-bind ARGS.
Useful to reset all bookmarks attributes to position in current buffer.
Ensure helm-select-action doesn't try to preselect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )