Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes old PDAs #22671

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

JohnFulpWillard
Copy link
Contributor

Document the changes in your pull request

  • Removes all instances of old PDAs
  • Removes PDA Painter (can be re-added if new PDAs get a need for them)
  • Removes message console's ability to fake messages (it only worked for old PDAs, can re-add if you make them work on new ones instead)
  • Replaces pAI's messenger with their own tablet so they actually get to keep theirs.

Why is this good for the game?

old PDAs are nearly completely unused and the few places they are used barely function, faking messages is utterly useless to anyone that isn't a pAI, and said pAI would then just immediately question why they are getting a PDA message when there's no way to obtain one in-game.
This is all just very messy and fucked up so it's better to remove them and start better support for the new PDAs in the future instead.

Testing

Tested pAIs buying and using their new PDA
Tested pAIs using their signaler cause I messed with that
Tested changing people's names as Admin to ensure PDAs were renamed as well

Not really much else to test since basically everything else is removal.

Changelog

🆑
rscdel: Removed old PDAs, PDA painters, and fake messaging with the telecomms messaging monitor console.
/:cl:

@JohnFulpWillard JohnFulpWillard requested a review from a team as a code owner October 3, 2024 01:27
@Yogbot-13 Yogbot-13 added the Revert / Deletion Altoids is probably mad about this label Oct 3, 2024
@ynot01
Copy link
Contributor

ynot01 commented Oct 3, 2024

Removes message console's ability to fake messages (it only worked for old PDAs, can re-add if you make them work on new ones instead)

A new console function is not needed since PDAs can set their username to anything they like, all the syndicates need is access to PDAs

@github-actions github-actions bot added the Mapping Will result in a change to a map. label Oct 3, 2024
@AMyriad
Copy link
Contributor

AMyriad commented Oct 3, 2024

I knew this day would come
alas just renaming them to "antique PDAs" couldn't save them 😔 (thanks for doing this)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mapping Will result in a change to a map. Revert / Deletion Altoids is probably mad about this
Projects
Development

Successfully merging this pull request may close these issues.

4 participants