Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test ideas command #199

Closed
wants to merge 1 commit into from
Closed

Add test ideas command #199

wants to merge 1 commit into from

Conversation

prideloki
Copy link

Short description of what this resolves:

  • Improve tests

Changes proposed in this pull request:

  • Add test to ideas subcommand

Fixes: #71

@manparvesh
Copy link
Member

@prideloki the tests are failing so I can't merge this

@prideloki
Copy link
Author

@manparvesh i'm sorry, i was busy at work. i will fix it within this week.

@codecov-io
Copy link

Codecov Report

Merging #199 into master will decrease coverage by 3.65%.
The diff coverage is 53.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #199      +/-   ##
==========================================
- Coverage   77.74%   74.09%   -3.66%     
==========================================
  Files          55       44      -11     
  Lines        3191     2799     -392     
==========================================
- Hits         2481     2074     -407     
- Misses        710      725      +15
Impacted Files Coverage Δ
tests/life/test_ideas.py 61.11% <53.33%> (-38.89%) ⬇️
modules/dev.py 75.46% <0%> (-9.58%) ⬇️
modules/learn.py 63.23% <0%> (-8.52%) ⬇️
modules/util.py 73.33% <0%> (-1.93%) ⬇️
modules/love.py 64% <0%> (-0.59%) ⬇️
yoda.py 92.43% <0%> (-0.31%) ⬇️
tests/dev/test_mp3cutter.py 100% <0%> (ø) ⬆️
modules/entertainment.py
resources/hackerearth/settings.py
tests/dev/test_whois.py
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d05227...cc50f02. Read the comment docs.

@prideloki
Copy link
Author

Sorry, i don't have time now to completely fix the error. 😞

@prideloki prideloki closed this Oct 28, 2018
@prideloki prideloki deleted the ideas_test branch October 28, 2018 07:46
@manparvesh
Copy link
Member

@prideloki it's okay, you are welcome to contribute whenever you have time in the future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants