Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flashcard test #109

Merged
merged 4 commits into from
May 29, 2018
Merged

Flashcard test #109

merged 4 commits into from
May 29, 2018

Conversation

ybfe1853
Copy link

@ybfe1853 ybfe1853 commented May 28, 2018

Short description of what this resolves:

Add test cases for flashcard functionality

Changes proposed in this pull request:

-Addition of test cases for flashcard
-Re obtain reference to selected set in select_set function and set_status function to account for the possibility of set creation for the first time
-add else clause to set status to account for possibility of no cards being created for a particular set

Fixes: #71

@codecov-io
Copy link

Codecov Report

Merging #109 into master will increase coverage by 6.17%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #109      +/-   ##
=========================================
+ Coverage   65.63%   71.8%   +6.17%     
=========================================
  Files          30      30              
  Lines        1673    1706      +33     
=========================================
+ Hits         1098    1225     +127     
+ Misses        575     481      -94
Impacted Files Coverage Δ
tests/learn/test_flashcards.py 100% <100%> (ø) ⬆️
modules/learn.py 62.54% <100%> (+28.21%) ⬆️
modules/util.py 72.22% <0%> (+11.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update badaa34...a13d4b1. Read the comment docs.

@manparvesh
Copy link
Member

@ybfe1853 this looks great! I'm merging this. Thanks for contributing! 😄

@manparvesh manparvesh merged commit fd604ef into yoda-pa:master May 29, 2018
@manparvesh manparvesh added this to the v0.3.0 milestone May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants