Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

composables-User情報管理体制整理 | ApiClientの修正 #83

Merged
merged 4 commits into from
May 12, 2024

Conversation

Shion1305
Copy link
Member

PRで実装される機能

PRで修正される機能

  • ApiClientでResponseが空の時でのエラーハンドリングができていなかった
  • Userdataの管理が useLoginuseUserInfo で跨っていた. useUserInfo が更新されても useLoginでのuserdataが更新されないため、welcomeページからの遷移ができていなかった
    useUserInfo を廃止。

レビューをお願いしたいポイント

当該事象の問題点について確認お願います~

Copy link
Collaborator

@Ryo-Sasaki-xxx Ryo-Sasaki-xxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

えるじーてぃーみー

@Shion1305 Shion1305 merged commit 27082d7 into develop May 12, 2024
2 checks passed
@Shion1305 Shion1305 deleted the shion/fix-71 branch May 12, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 User情報変更時のリクエスト異常
2 participants