Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved exceptions and tests for them #59

Closed
wants to merge 2 commits into from
Closed

Conversation

peterfox
Copy link
Collaborator

Changes In Code

Better exceptions

Issue ticket number / Business Case

Some exceptions where confusing.

Checklist before requesting a review

  • I have written PHPUnit tests.
  • I have updated the documentation and opened a pull request within
    the feature flags documentation repo.
  • I have checked code styles, PHPStan etc. pass.
  • I have provided an issue/business case.
  • I have added the enhancement label for a new feature.

@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (39baec4) 83.09% compared to head (ff3ea2b) 82.57%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/Exceptions/FileNotFound.php 50.00% 2 Missing ⚠️
src/Exceptions/GatewayConfigurationMissing.php 50.00% 2 Missing ⚠️
src/Exceptions/UnableToLoadFlags.php 50.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #59      +/-   ##
============================================
- Coverage     83.09%   82.57%   -0.53%     
- Complexity      202      208       +6     
============================================
  Files            31       34       +3     
  Lines           556      568      +12     
============================================
+ Hits            462      469       +7     
- Misses           94       99       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterfox peterfox closed this Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant