Various spillmap fixes. #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We found out the hard way that if we allow this kind of instruction through it deletes a load of essential state! Co-authored-by: Lukas Diekmann <[email protected]>
This uses a set to track precisely how many mappings are required. This means we can bomb-out if there are more than we can handle. Co-authored-by: Edd Barrett <[email protected]>
As-is, we were using the internal LLVM register numbers in the mapping, meaning that we didn't consider (e.g.) `rax` and `eax` as the same register! Fixes a bf.c test when mem2reg is used in the AOT pipeline. Co-authored-by: Edd Barrett <[email protected]>
Co-authored-by: Edd Barrett <[email protected]>
Co-authored-by: Edd Barrett <[email protected]>
|
(We fixed the nested loop thing, but some of the awfy benchmarks still don't always work, but we've made the executive decision to move onwards with this so that Lukas can re-write this section of the code so that it can handle >2 extra locations -- it's not ideal, but the branch is getting so long-lived/complicated...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a collection of fixes for the spillmap algorithm that calculates extra locations for live variables.