Fix liveness analysis when dealing with phi nodes. #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah sorry, I already applied the first commit earlier :) |
vext01
reviewed
Aug 13, 2024
vext01
reviewed
Aug 13, 2024
vext01
reviewed
Aug 13, 2024
|
A few comments. Trying to ensure that my future self will be able to easily understand this next time I read it :) |
|
Ok to squash? |
|
Please squash. |
Our previous approach of handling the operands of phi nodes wasn't entirely correct. See comments for a more detailed explanation.
ptersilie
force-pushed
the
fix_liveness
branch
from
182197e to
7fc95eb
Compare
|
Squashed and rebased. |
This was referenced Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.