Add pass for splitting blocks after calls. #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we add a simple test to check the splitting works when the flag is turned on? I also wouldn't mind if @vext01 could cast a very quick eye over this, as I admit to ignorance when looking in LLVM's internals. I don't think @vext01 needs to be a reviewer for subsequent changes/fixes -- a quick eye should be sufficient. |
vext01
reviewed
Dec 7, 2023
vext01
reviewed
Dec 7, 2023
|
Ready for re-review. |
|
Please squash. |
This effectively turns call instructions into terminators, making it easier to process traces.
ptersilie
force-pushed
the
splitblocksaftercalls
branch
from
908c185 to
05ab891
Compare
|
Squashed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This effectively turns call instructions into terminators, making it easier to process traces in yk. A yk PR with major jitmodbuilder changes (rewriting the entire recursion/external call detection logic) is following soon.