Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/fix tests for new shadow stack allocation scheme. #1520

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

vext01
Copy link
Contributor

@vext01 vext01 commented Dec 19, 2024

Requires ykjit/ykllvm#220 (and a ykllvm sync)

@ltratt
Copy link
Contributor

ltratt commented Dec 20, 2024

Please force push a ykllvm sync.

@vext01
Copy link
Contributor Author

vext01 commented Dec 20, 2024

I rebased, synced ykllvm and force pushed.

(The "compare" contains what I assume is the result of the rebase, so may contain more than you expected)

@vext01
Copy link
Contributor Author

vext01 commented Dec 20, 2024

hold off this for a moment, just realised the rebase causes test failures.

@vext01
Copy link
Contributor Author

vext01 commented Dec 20, 2024

test fixed with another force push.

@ltratt
Copy link
Contributor

ltratt commented Dec 20, 2024

Probably this means that we can delete peel1.swt.c and remove || test "$YKB_TRACER" = "swt" from peel1.c. In other words, we can probably use one test for both hwt and swt, which would be nice!

@vext01
Copy link
Contributor Author

vext01 commented Dec 20, 2024

test seems to pass, so great.

@vext01
Copy link
Contributor Author

vext01 commented Dec 20, 2024

(force pushed, btw)

@ltratt
Copy link
Contributor

ltratt commented Dec 20, 2024

Thanks!

@ltratt ltratt added this pull request to the merge queue Dec 20, 2024
Merged via the queue into ykjit:master with commit 66c9114 Dec 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants