Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor inspect: pass set by value #12

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Refactor inspect: pass set by value #12

merged 1 commit into from
Nov 23, 2023

Conversation

alexandear
Copy link
Contributor

This PR refactors unexported function inspect. We can pass set by value instead of a pointer because map internally is a pointer.

ykadowak
ykadowak approved these changes Nov 23, 2023
View reviewed changes
Copy link
Owner

@ykadowak ykadowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch.

@ykadowak ykadowak merged commit 903c0a7 into ykadowak:main Nov 23, 2023
2 checks passed
@alexandear alexandear deleted the refactor-inspect branch November 23, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykadowak ykadowak ykadowak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandear @ykadowak