Skip to content

Conversation

terabytesoftw
Copy link
Member

Q A
Is bugfix? ✔️
New feature?
Breaks BC?

@Copilot Copilot AI review requested due to automatic review settings October 15, 2025 20:19
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds additional revisions to .git-blame-ignore-revs to exclude specific refactor/test-related commits from git blame, keeping history noise-free.

  • Adds two commit SHAs to ignore in blame.
  • Documents each ignored commit with a short context comment.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@mspirkov
Copy link
Contributor

I don't think such changes should be ignored. I think these changes are important in the context of testing.
I think it's better to ignore code style changes or any edits that aren't important.
I could be wrong, I'd be glad to hear another point of view.

@terabytesoftw
Copy link
Member Author

I don't think such changes should be ignored. I think these changes are important in the context of testing. I think it's better to ignore code style changes or any edits that aren't important. I could be wrong, I'd be glad to hear another point of view.

The basic reasons for excluding it are as follows:

  1. They are tests, not repository code.
  2. They simply add static to a method and return an array, which is commonly used in PHPUnit dataProviders.
  3. Deprecated methods are replaced with their PHPUnit equivalents; the PHPUnit documentation specifies this.
  4. The behavior and logic of the tests are maintained; everything remains the same, but without deprecations.

@mspirkov
Copy link
Contributor

I think what you described is refactoring. I'm not sure commits with refactorings aren't important. Besides, these commits don't really break Git Blame, in my opinion.
In any case, it's not very important, I just wanted to clarify for myself :)

@terabytesoftw
Copy link
Member Author

terabytesoftw commented Oct 16, 2025

I think what you described is refactoring. I'm not sure commits with refactorings aren't important. Besides, these commits don't really break Git Blame, in my opinion. In any case, it's not very important, I just wanted to clarify for myself :)

If we leave it, we would lose who actually did the tests in each PR, which has CHANGELOG.md, simply all these updates are to update us to PHPUnit 10, but in essence the tests do not change.

@samdark samdark merged commit ca108e2 into yiisoft:master Oct 16, 2025
2 checks passed
@terabytesoftw terabytesoftw deleted the add-git-blame-ignore-revs-8 branch October 16, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants