Feature/view ld json noscript #20001
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pgaultier
commented
Oct 9, 2023
pgaultier
commented
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ✔️ |
| Breaks BC? | ✔️ |
| Fixed issues |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #20001 +/- ##
==========================================
- Coverage 48.94% 48.93% -0.01%
==========================================
Files 445 445
Lines 42817 42841 +24
==========================================
+ Hits 20956 20964 +8
- Misses 21861 21877 +16
☔ View full report in Codecov by Sentry. |
|
You could add a unit test, Thks, |
|
I'm not sure if we should add it. What do you think @yiisoft/reviewers ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.