-
-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Match with enable logging and profiling #314
base: master
Are you sure you want to change the base?
Match with enable logging and profiling #314
Conversation
ziaratban
commented
Jul 2, 2020
Q | A |
---|---|
Is bugfix? | yes |
New feature? | no |
Breaks BC? | no |
Tests pass? | yes |
see yii\mongodb\Connection::enableLogging and yii\mongodb\Connection::enableProfiling
main purpose |
Co-authored-by: Alexander Makarov <[email protected]>
Co-authored-by: Alexander Makarov <[email protected]>
Co-authored-by: Alexander Makarov <[email protected]>
Co-authored-by: Alexander Makarov <[email protected]>
Co-authored-by: Alexander Makarov <[email protected]>
Co-authored-by: Alexander Makarov <[email protected]>
Co-authored-by: Alexander Makarov <[email protected]>
Co-authored-by: Alexander Makarov <[email protected]>
Co-authored-by: Alexander Makarov <[email protected]>
base on : yiisoft#314
https://travis-ci.com/github/yiisoft/yii2-mongodb/jobs/357995598#L1572 - fails tests on connection. |
70d76cc
to
1e760fe
Compare
@samdark please see |
@ziaratban referencing Yii::$app->mongodb is incorrect. You should use connection. |
fixed. |
Seems tests aren't alright with new code. |
I think this is about test case. (#316 ) |
No, it should not be since tests are alright in master branch. |
i merged branch |
The change looks valid, yes. I wonder why tests do pass then in master. Must be uncovered case... |
No, I think no uncovered cases exist. A wrong direction has gone through, across the 'test case' project. Mongodb's component is not used. Docs say this about the
|
61e732c
to
dd7c555
Compare