Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better performance for exists() method of Query class #298

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

better performance for exists() method of Query class #298

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dca4125
Update Query.php
ziaratban Feb 14, 2020
633ed73
Update Query.php
ziaratban Feb 25, 2020
a0c575b
Merge pull request #1 from yiisoft/master
ziaratban Oct 30, 2020
5d31448
Merge branch 'master' into performance-query-exists
ziaratban Oct 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions src/Query.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,7 +495,28 @@ public function exists($db = null)
if (!empty($this->emulateExecution)) {
return false;
}

/**
* better performance
* please read this article : Checking if a document exists – MongoDB slow findOne vs find
* https://blog.serverdensity.com/checking-if-a-document-exists-mongodb-slow-findone-vs-find/
*/
#save last options
$tmpOrderBy = $this->orderBy;
$tmpLimit = $this->limit;
$tmpOffset = $this->offset;
$tmpSelect = $this->select;
$this->orderBy = [];
$this->limit = 1;
$this->offset = null;
$this->select = ['_id'];
$cursor = $this->buildCursor($db);
#return last options
$this->orderBy = $tmpOrderBy;
$this->limit = $tmpLimit;
$this->offset = $tmpOffset;
$this->select = $tmpSelect;

foreach ($cursor as $row) {
return true;
}
Expand Down