Injection lazy loading #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vjik
commented
May 3, 2024
vjik
commented
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ✔️ |
| Breaks BC? | ❌ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #107 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 84 92 +8
===========================================
Files 7 9 +2
Lines 246 264 +18
===========================================
+ Hits 246 264 +18 ☔ View full report in Codecov by Sentry. |
Tigrov
approved these changes
May 3, 2024
samdark
requested changes
May 6, 2024
|
|
||
| use Psr\Container\ContainerInterface; | ||
|
|
||
| final class InjectionContainer implements InjectionContainerInterface |
There was a problem hiding this comment.
Looks like a dummy class that does nothing. Can we avoid it?
There was a problem hiding this comment.
We can use directly PSR container instead of it. But there are disadvantages:
- unnecessary method
has() - method
get()returnsmixed, so we should check that it is object and throw exception if no.
Co-authored-by: Alexander Makarov <[email protected]>
samdark
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.