Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add layout specific injections #102

Merged
merged 4 commits into from
May 14, 2024
Merged

Add layout specific injections #102

merged 4 commits into from
May 14, 2024

Conversation

vjik
Copy link
Member

@vjik vjik commented Apr 9, 2024

Q A
Is bugfix?
New feature? ✔️
Breaks BC?
Fixed issues Fix #101

@vjik vjik added the status:under development Someone is working on a pull request. label Apr 9, 2024
@vjik vjik marked this pull request as ready for review May 3, 2024 08:15
Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d3c4a9a) to head (66debe2).

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #102   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity        78        84    +6     
===========================================
  Files              6         7    +1     
  Lines            233       246   +13     
===========================================
+ Hits             233       246   +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik added status:code review The pull request needs review. and removed status:under development Someone is working on a pull request. labels May 3, 2024
@vjik vjik requested a review from a team May 3, 2024 08:20
src/ViewRenderer.php Outdated Show resolved Hide resolved
src/ViewRenderer.php Outdated Show resolved Hide resolved
src/ViewRenderer.php Outdated Show resolved Hide resolved
src/ViewRenderer.php Outdated Show resolved Hide resolved
@vjik vjik requested a review from samdark May 7, 2024 08:37
@vjik vjik merged commit d323372 into master May 14, 2024
23 checks passed
@vjik vjik deleted the layout-injections branch May 14, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add specify a layout in injections
3 participants