Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional default host and scheme to UrlGenerator #144

Merged
merged 4 commits into from
Mar 19, 2024

Conversation

vjik
Copy link
Member

@vjik vjik commented Mar 18, 2024

Q A
Is bugfix?
New feature? ✔️
Breaks BC?

Copy link

what-the-diff bot commented Mar 18, 2024

PR Summary

  • Added Feature for Specifying Default Host and Scheme
    The update includes a new feature in the UrlGenerator class that lets users outline a default host and scheme. In other words, it creates a standard template for URL creation when not specified in unique cases. This adjustment is applied in the constructor phase of the UrlGenerator and can be overridden later as needed.

  • Updated generateAbsolute Method to Apply Default Settings
    There have been changes in the generateAbsolute method within the UrlGenerator class. Now, when generating a complete URL, if a host or a scheme value isn't provided individually, the method draws from the now available default host and scheme. This change provides increased flexibility and customization to URL generation.

  • Inclusion of New Test Cases
    New test scenarios have been added to verify the performance and validity of the updated components within the UrlGenerator class. It ensures the newly integrated feature of default host and scheme fully performs as designed.

  • Addressing Formatting Issue in UrlGeneratorTest Class
    This change corrects a formatting problem identified in the UrlGeneratorTest class. This correction ensures improved readability and comprehension of the tests.

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.50%. Comparing base (77da24c) to head (8e00264).

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #144      +/-   ##
============================================
+ Coverage     99.48%   99.50%   +0.01%     
+ Complexity       85       83       -2     
============================================
  Files             2        2              
  Lines           195      200       +5     
============================================
+ Hits            194      199       +5     
  Misses            1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik added the status:code review The pull request needs review. label Mar 18, 2024
@vjik vjik requested a review from a team March 18, 2024 15:31
@vjik vjik merged commit 27787bb into master Mar 19, 2024
23 checks passed
@vjik vjik deleted the improve-url-generator branch March 19, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants