Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused code + Improve GitHub actions #136

Merged
merged 3 commits into from
Dec 24, 2023
Merged

Remove unused code + Improve GitHub actions #136

merged 3 commits into from
Dec 24, 2023

Conversation

vjik
Copy link
Member

@vjik vjik commented Dec 24, 2023

Q A
Is bugfix?
New feature?
Breaks BC?

Copy link

what-the-diff bot commented Dec 24, 2023

PR Summary

  • Removal of Redundant Line in Pull Request Template
    The "Fixed issues" line in the Pull Request Template, which was not crucial, has been removed, for less clouded PR creation.

  • Dependencies Maintenance Schedule Update
    The schedule on which the software dependencies get updated has been modified. This will ensure that we use more updated and efficient versions of the libraries.

  • Workflow Triggers Optimization in the bc.yml file
    Workflows triggers are now ignoring certain files. This means that the workflow will not run for irrelevant changes, saving processing power.

  • Workflow Triggers Adjustment in Files
    A bulk of changes were made in the build.yml, composer-require-checker.yml, mutation.yml, rector.yml, and static.yml files. These primarily deal with when and on which branches our automated workflows should run. This ensures we only carry out necessary operations at the right times.

  • Upgrade of PHP Version in the rector.yml Workflow
    The PHP version used in the rector.yml workflow has been updated. This leads to improved performance and enhanced security.

  • Added Contributor Information in Changelog
    The CHANGELOG.md file has been updated with more detailed contributor information. This provides credit where it's due and offers transparency into who made certain changes.

  • Codebase Simplification in UrlGenerator.php
    The variable notSubstitutedArguments and associated code has been deleted from the src/UrlGenerator.php file. This simplifies our codebase, making it easier to maintain.

Copy link

codecov bot commented Dec 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7839246) 99.49% compared to head (280d319) 99.48%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #136      +/-   ##
============================================
- Coverage     99.49%   99.48%   -0.01%     
  Complexity       85       85              
============================================
  Files             2        2              
  Lines           197      195       -2     
============================================
- Hits            196      194       -2     
  Misses            1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik requested a review from a team December 24, 2023 08:59
@vjik vjik added the status:code review The pull request needs review. label Dec 24, 2023
@vjik vjik merged commit bc3eb5e into master Dec 24, 2023
23 of 24 checks passed
@vjik vjik deleted the improve branch December 24, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants