Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #133, #134: Don't add not substituted arguments and empty values to query string #135

Merged
merged 4 commits into from
Dec 23, 2023

Conversation

rustamwin
Copy link
Member

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues #133 #134

@rustamwin rustamwin added the status:code review The pull request needs review. label Dec 23, 2023
@rustamwin rustamwin requested a review from a team December 23, 2023 17:33
Copy link

what-the-diff bot commented Dec 23, 2023

PR Summary

  • Correction in Comment
    A spelling mistake was corrected in a comment in src/UrlGenerator.php. The modified comment now reads: // All required arguments are available..

  • Query String Generation Refactoring
    The code in src/UrlGenerator.php that was handling the creation of the query string has been improved. It now checks whether there are any query parameters before it attempts to build a query string. This should make the URL generation more efficient, as unnecessary strings won't be generated if they're not needed.

  • Test Names and Parameters Modified
    Several tests within tests/UrlGeneratorTest.php have been redesigned with new naming conventions and parameters to better reflect the functionality they're checking. These changes should make the tests simpler since they now deal with fewer parameters and less complicated scenarios.

  • Methods Updated in src/UrlGeneratorTest.php and tests/UrlMatcherTest.php
    The method addGroup() was replaced with addRoute() within src/UrlGeneratorTest.php and tests/UrlMatcherTest.php. This highlights a shift from group-based URL management to individual route management, which should provide a more direct way to handle URLs. The change should enhance the comprehensibility and maintainability of the code.

Copy link

codecov bot commented Dec 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (286474f) 99.49% compared to head (b2d6730) 99.49%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #135      +/-   ##
============================================
- Coverage     99.49%   99.49%   -0.01%     
  Complexity       85       85              
============================================
  Files             2        2              
  Lines           198      197       -1     
============================================
- Hits            197      196       -1     
  Misses            1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samdark samdark merged commit 7839246 into master Dec 23, 2023
17 checks passed
@samdark samdark deleted the fix-134 branch December 23, 2023 18:40
@samdark
Copy link
Member

samdark commented Dec 23, 2023

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants