Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve arguments validation + Minor refactoring + Psalm 1 #62

Merged
merged 10 commits into from
Feb 17, 2024
Merged

Conversation

vjik
Copy link
Member

@vjik vjik commented Feb 17, 2024

Q A
Is bugfix?
New feature?
Breaks BC?

Copy link

what-the-diff bot commented Feb 17, 2024

PR Summary

  • Introduction of Branch Filter for Push Events
    Added functionality that allows the GitHub Actions workflow to filter out certain branches for push events. This could help your team control and manage the code pushed into different branches.

  • Expansion of PHP Version Compatibility
    The PHP static analysis job has been updated to broaden the PHP version compatibility. It now includes support for versions 8.0, 8.1, 8.2, and 8.3. This widens user accessibility by ensuring the code runs on multiple PHP versions.

  • Addition of New Configuration File for Static Analyzer
    Introduced a new configuration file for Psalm static analyzer, which is a tool used to find errors in PHP applications. This helps to maintain code quality and avoid potential issues.

  • Update of Package Version Requirements
    Upgraded requirements for vimeo/psalm package to the newer version (5.22). This update provides more updated features and fixes from the package.

  • Reduced Error Level for Static Analyzer
    The error level attribute has been decreased in the Psalm configuration file. This means the static analyzer will now report fewer types of potential errors. This is done to focus on more critical issues and reduce noise from less important warnings.

  • New Server Type Added
    A new server type has been added to the Memcached.php script. This offers more options to decide where and how to deploy your application.

  • Improvements in the Handling of Data Types
    Updated several methods in Memcached.php script, enabling them to handle more extensive data types. This improves robustness and flexibility of the code in managing data.

  • Addition of Test Case
    A new test case added to MemcachedTest.php ensures that the code behaves as expected when dealing with non-string keys. This improves reliability of the code by validating this specific scenario.

@vjik vjik added the status:code review The pull request needs review. label Feb 17, 2024
@vjik vjik requested a review from a team February 17, 2024 09:26
@vjik vjik merged commit 415561e into master Feb 17, 2024
20 of 21 checks passed
@vjik vjik deleted the psalm branch February 17, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants