build: remove custom rxjs imports rule in favor of import-banlist rule (

angular#18157)
yifange · Jan 30, 2020 · 67bbde3 · 67bbde3
1 parent c4392c9
commit 67bbde3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 25 deletions.
diff --git a/tools/tslint-rules/rxjsImportsRule.ts b/tools/tslint-rules/rxjsImportsRule.ts
diff --git a/tslint.json b/tslint.json
@@ -114,7 +114,6 @@
     "no-undecorated-class-with-ng-fields": true,
     "setters-after-getters": true,
     "ng-on-changes-property-access": true,
-    "rxjs-imports": true,
     "require-breaking-change-version": true,
     "class-list-signatures": true,
     "coercion-types": [true,
@@ -182,7 +181,9 @@
       ".*": "kebab-case"
     }],
     "no-unescaped-html-tag": true,
-    "import-blacklist": [true, ["^@schematics/angular/.*(ast).*"]]
+    // Ensures that all rxjs imports come only from `rxjs` and `rxjs/operators`. Also ensures
+    // that no AST utils from `@schematics/angular` are imported. These should be vendored.
+    "import-blacklist": [true, ["^@schematics/angular/.*(ast).*", "^rxjs(?!$|/operators$).*"]]
   },
   "linterOptions": {
     "exclude": [