Fix for autocrlf and failing tests issue on Windows #1872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
of text files using as data for tests.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cloning repository on Windows with autocrlf git option enabled causes changes in line ending style for html ant txt files using in tests. That leads to failing of following tests (because files size gets bigger):
ServerTest.HeadMethod200Static
ServerTest.GetMethodDir
ServerTest.StaticFileRangeBigFile
ServerTest.StaticFileRangeBigFile2
ServerTest.StaticFileBigFile
Proposed solution introduces .gitattributes file to control line ending style for individual files.