Fix range parser when parsing too many ranges #1812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jimmy-park thanks for the fix. Could you check the performance difference between the regex implementation and the new implementation? I believe the new one should outperform the regex one, but I would like to confirm it before merge the pull request. Thanks! |
|
Here is a simple benchmark result. |
|
@jimmy-park great job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack overflow is detected by AddressSanitizer on MSVC when parsing too many ranges using
std::regex.ServerTest.GetStreamedWithTooManyRangeshas failed due to this reason.I would like to suggest a range parser with plain string manipulations rather than relying on
std::regex.And some test cases are added for invalid ranges not covered by the current implementation.