Performance: reserve body to avoid frequent reallocations and copies #1782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArnaudBienner
commented
Feb 23, 2024
|
@ArnaudBienner thanks for the pull request. The fuzzing test failed. I re-run two more times, but it always fails. Could you take a look at the log? |
|
@yhirose I'll have a look. I suspect this is due to the max limit being too high resulting in memory allocation failures. Apart from that, do you think this is the good way to improve the performance I had, or is #1781 is better? If you think the other PR is preferable, I can simply close this PR without further investigation. |
|
Yes, you can just close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative approach to #1781.
It is simpler: only one line, the checks on length have already been made.
But I wasn't sure if it was OK or not, since this implies
xhas abodymember, so it makes this template function less generic, which might defeat the purpose of having a template here...