Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use StatusCode in tests and examples #1743

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Use StatusCode in tests and examples #1743

merged 2 commits into from
Dec 20, 2023

Conversation

bugdea1er
Copy link
Contributor

The final follow-up for #1739

Replaced number status codes with the new enum constants in tests and examples

@yhirose should I do the same for README?

@yhirose
Copy link
Owner

yhirose commented Dec 20, 2023

should I do the same for README?

Yes, please!

@bugdea1er
Copy link
Contributor Author

@yhirose done!

@yhirose
Copy link
Owner

yhirose commented Dec 20, 2023

@bugdea1er thanks for the great help!

@yhirose yhirose merged commit 5b943d9 into yhirose:master Dec 20, 2023
4 checks passed
@bugdea1er bugdea1er deleted the use-status-code branch December 20, 2023 22:29
@bugdea1er
Copy link
Contributor Author

@yhirose any plans for a release with this changes in the near future?

@yhirose
Copy link
Owner

yhirose commented Dec 22, 2023

@bugdea1er v0.14.3 is now released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants