Support adding pages #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatimblin
reviewed
Dec 27, 2022
yen-tt
reviewed
Dec 27, 2022
yen-tt
reviewed
Dec 27, 2022
yen-tt
reviewed
Dec 27, 2022
yen-tt
reviewed
Dec 27, 2022
yen-tt
reviewed
Dec 27, 2022
tmeyer2115
reviewed
Dec 28, 2022
yen-tt
reviewed
Dec 28, 2022
packages/studio/tests/store/createPageSlice.activeComponentActions.test.ts
Outdated
Show resolved
Hide resolved
tmeyer2115
reviewed
Dec 28, 2022
yen-tt
approved these changes
Dec 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for adding new pages through the UI and saving them in the store via a new
addPageaction. The UI is also updated to display a list of the pages and it allows you to click on the names to switch between them. This PR also makes other changes that are described in the page operations tech design:setPagesfrom thePageSliceActionssetActivePageNamependingChangessection ofPageSliceStateswithpagesToUpdatesetActivePageStateandsetActiveComponentPropsto update thepagesToUpdateJ=SLAP-2498
TEST=auto, manual
See that the new and existing Jest tests pass. In the test-site, see that clicking the button for adding a page causes a modal to appear. Only valid page names are accepted and actually create a page.
Screen.Recording.mov