Ensure html_nested returns the inner type#3493
Open
ranile wants to merge 3 commits intoyewstack:masterfrom
Open
Ensure html_nested returns the inner type#3493ranile wants to merge 3 commits intoyewstack:masterfrom
ranile wants to merge 3 commits intoyewstack:masterfrom
Conversation
5493421 to
169f6bc
Compare
|
Visit the preview URL for this PR (updated for commit ba98704): https://yew-rs-api--pr3493-html-nested-types-6gu7o8xf.web.app (expires Sat, 04 Nov 2023 14:53:46 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Benchmark - coreYew MasterPull Request |
Member
Author
|
Compile failures will be resolved by #3453 |
Size ComparisonDetails
✅ None of the examples has changed their size significantly. |
169f6bc to
95a4b26
Compare
95a4b26 to
688b753
Compare
Benchmark - SSRYew MasterDetails
Pull RequestDetails
|
Member
|
I feel this is an expected behaviour. See: https://docs.rs/yew/latest/yew/macro.html_nested.html
The documentation suggested that only Returning other types would encourage inspection of VNode, which I am not in favour of. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
At some point in time, html_nested broke and started returning VNode instead of inner types. This PR fixes that
Checklist