Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add override for deprecated #845

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mnaoumov
Copy link

@mnaoumov mnaoumov commented Jan 20, 2025

Purpose of this pull request?

  • Documentation update
  • Bug fix
  • Enhancement
  • Other, please explain:

What changes did you make?

  • Add override from deprecated clone-stats to its modern fork
  • Add npm-shrinkwrap.json to the package to ensure the override is respected during npm install -g

Is there anything you'd like reviewers to focus on?

Fixes #844

Copy link

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Thanks for sending this in! I don't think this is the strategy we'll want to take, though. It's cleaner -and healthier for the ecosystem!- to report problems upstream to dependents. Once the dependents fix those problems we won't have to do any fancy things with them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeprecationWarnings: punycode and clone-stats
2 participants