-
Notifications
You must be signed in to change notification settings - Fork 338
Pass options.type to FileProcessor if present #524
Conversation
@mhupman Need some tests. |
|
@mhupman ok good catch! |
friendly ping @mhupman |
I don't mind taking a stab at, but honestly, I'm not sure where to start. Any pointers or thoughts about what you'd like to see in the test? |
Just a try:
fails with the current version, but
to
|
@veraee in usemin.js, I think it should be :
|
I'm ok with that, but I think your issue is already adressed in lines 108--110
which already uses this.target as fallback if the user has not set options.type |
I'm working on this PR. Will come back soon. |
Closing in favor of #542 |
This should address some of the issues experienced in #255 when using configuration like the following:
This change allows FileProcessor to process the file as
html
instead offoo-html
, the latter of which won't get built-in pattern support.