chore: bumped ESLint and Prettier devDeps to latest (flat config) #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected], npm/[email protected] |
4 tasks
4 tasks
UlisesGascon
approved these changes
Mar 20, 2025
Member
UlisesGascon
left a comment
UlisesGascon
left a comment
There was a problem hiding this comment.
LGTM! Thanks @JoshuaKGoldberg!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request?
Fixes #270.
What changes did you make?
Bumps packages with
eslint,prettier, and/orxoin their name to the latest. This brought in ESLint 9, which defaults to only allowing flat config. I figured this was a good time to make the switch rather than set the env flag to allow the legacy eslintrc + eslintignore config.Switches linting from a
pretestscript tolint, so that it doesn't run matrixed in CI for every Node.js version. There's no benefit to running the linter in older Node versions. Lint rules shouldn't change on the Node.js version.Is there anything you'd like reviewers to focus on?
The Prettier settings mimic what was here before. Prettier's changed some defaults since but I didn't want to get into that now.
This should partially unblock #269.