Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add beanprice to Docker image #35

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Add beanprice to Docker image #35

merged 1 commit into from
Jan 5, 2024

Conversation

fdw
Copy link
Contributor

@fdw fdw commented Jan 4, 2024

Unfortunately, beanprice isn't on PyPi and hasn't had a release in years. Therefore, we have to use to just install what's in the repo...

Closes: #32

@yegle
Copy link
Owner

yegle commented Jan 4, 2024

It looks like you can specify a git repo in requirements.txt in format like this:

package-two @ git+https://github.com/owner/repo@41b95ec

(Reference: https://stackoverflow.com/questions/16584552/how-to-state-in-requirements-txt-a-direct-github-source)

Can you update the requirements.txt file instead?

Also, since it doesn't have a release, can you specify the latest commit hash with a link to that commit, to make it easier to review?

Unfortunately, beanprice isn't on PyPi
(beancount/beanprice#3) and hasn't had a
release in years (beancount/beanprice#84).
Therefore, we have to use to just install what's in the repo...

Issue: #32
@fdw
Copy link
Contributor Author

fdw commented Jan 4, 2024

First, thanks 🙂

Can you update the requirements.txt file instead?

I tried that first, but it's installed with --require-hashes, but pip can't calculate a hash from a source repo. I preferred to add a new line over removing the hashes from the other packages.

Also, since it doesn't have a release, can you specify the latest commit hash with a link to that commit, to make it easier to review?

That's a good idea. Will do 🙂

@grostim
Copy link

grostim commented Jan 5, 2024

I have created a fork of yegle's image specifically to comply with my needs including, but not limited to, the inclusion of bean-price.
I will not do a pull request for it as it is too "dirty" for general usage.
Feel free to use it at your own risk.
https://github.com/grostim/fava-docker
https://hub.docker.com/r/grostim/fava-docker/tags

@yegle yegle merged commit d3a2b01 into yegle:master Jan 5, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include beanprice
3 participants