Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert file path returned from LSP in Cygwin #432

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Convert file path returned from LSP in Cygwin #432

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion autoload/lsp/util.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,12 @@ export def LspUriToFile(uri: string): string
if uri_decoded =~? '^file:///\a:'
# MS-Windows URI
uri_decoded = uri_decoded[8 : ]
uri_decoded = uri_decoded->substitute('/', '\\', 'g')
if has("win32unix") # we're in Cygwin
# The substitution is to remove the '^@' escape character from the end of line.
uri_decoded = system($'cygpath --unix {uri_decoded}')->substitute('^\(\p*\).*$', '\=submatch(1)', "")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invoking an external command for decoding every URI may incur a lot of overhead. Is cygpath used to only the '^@' character from the end of the line? Is it possible to remove it using trim()?

else
uri_decoded = uri_decoded->substitute('/', '\\', 'g')
endif
# On GNU/Linux (pattern not end with `:`)
elseif uri_decoded =~? '^file:///\a'
uri_decoded = uri_decoded[7 : ]
Expand Down